Skip to content

init script fixes #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stavros-k wants to merge 7 commits into
base: master
Choose a base branch
from
+8 −7
Open

init script fixes #214

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
65f9a20
fix: replace double brackets with single brackets for POSIX complianc…
stavros-k Jan 27, 2026
e728ee5
fix: remove exit command to allow further initialization steps in koe…
stavros-k Jan 27, 2026
b0353c8
set the pph ini var,
stavros-k Jan 27, 2026
5f0c21b
fix: create .env file during application setup in Dockerfile
stavros-k Jan 27, 2026
700d2e9
fix: remove .env file creation from Dockerfile and ensure it's create…
stavros-k Jan 27, 2026
78591aa
revert
stavros-k Jan 27, 2026
5b7811a
Apply suggestion from @stavros-k
stavros-k Jan 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ FROM alpine:3.23.2
# The koel version to download
ARG KOEL_VERSION_REF=v8.3.0

ENV PHP_INI_DIR=/usr/local/etc/php

# Install dependencies
RUN apk add --no-cache --no-interactive \
curl \
Expand Down Expand Up @@ -67,7 +69,7 @@ COPY apache/httpd.conf /etc/apache2/
COPY apache/www.conf /etc/php84/php-fpm.d/

# Copy php.ini
COPY ./php.ini "$PHP_INI_DIR/php.ini"
COPY ./php.ini ${PHP_INI_DIR}/php.ini

# make crontab file
RUN touch /etc/crontabs/www-data
Expand Down
10 changes: 5 additions & 5 deletions koel-init
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
#!/bin/sh

if [[ ! -f /var/www/html/.env ]]; then
if [ ! -f /var/www/html/.env ]; then
echo "No .env file found in /var/www/html. Make sure to mount a .env file to store the configuration. You can use the koel:init command (see https://github.com/koel/docker#the-koelinit-command) for a guided setup."
echo ""
echo "See https://github.com/koel/koel/blob/master/.env.example for an example .env file."
exit 0
Comment thread
stavros-k marked this conversation as resolved.
Outdated
fi
Comment on lines +3 to 7
Copy link

Copilot AI Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR claims to close issue #213, which reports that the container won't run koel:init when environment variables are passed via docker-compose environment section (without mounting a .env file). However, this check still exits the script with exit 0 when the .env file is not found, preventing koel:init from running. This doesn't address the core issue described in #213. The script should either remove this check entirely or allow the script to continue when environment variables are provided through other means (e.g., checking if required environment variables are set).

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Member

@phanan phanan Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stavros-k WDYT?

Copy link
Copy Markdown
Author

@stavros-k stavros-k Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm all in to remove this, as it currently masks the fact that init does not work.
CI showed us that.


if [[ -z "${SKIP_INIT}" ]]; then
if [[ -z "${OPTIMIZE_CONFIG}" ]]; then
echo "Config not optimized. You can optimize the config with `OPTIMIZE_CONFIG`. Note that this will prevent config modifications from being applied until the container is restarted."
if [ -z "${SKIP_INIT}" ]; then
if [ -z "${OPTIMIZE_CONFIG}" ]; then
echo "Config not optimized. You can optimize the config with 'OPTIMIZE_CONFIG'. Note that this will prevent config modifications from being applied until the container is restarted."
else
echo "Optimizing config..."
# clear before caching, in case this is a container reboot and it was already cached from before
Expand All @@ -22,4 +22,4 @@ if [[ -z "${SKIP_INIT}" ]]; then
php artisan koel:init --no-assets --no-interaction
else
echo "Initialization skipped. koel might not work properly if it is misconfigured or if the database is out of date. This should not be used outside of debugging or manual initial setups!"
fi
fi