[WIP] Clean up and port MEGA P laser feature from TFT#540
Draft
stklcode wants to merge 2 commits intoknutwurst:masterfrom
Draft
[WIP] Clean up and port MEGA P laser feature from TFT#540stklcode wants to merge 2 commits intoknutwurst:masterfrom
stklcode wants to merge 2 commits intoknutwurst:masterfrom
Conversation
Migration from the original v1.2.9 firmware sourcecode to the current Marlin 2.x implementation. Move functions to AnycubicTouchscreenClass class and adjust Marlin calls.
stklcode
force-pushed
the
feature/anycubic-laser
branch
from
3c4cb04 to
084dfb2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Clean up the more or less neglected code snippets from the original Anycubic MEGA P laser feature.
Remove the
KNUTWURST_MEGA_P_LASERswitch and make all logic available withKNUTWURST_MEGA_P.(we might discuss this, maybe someone might like to disable it to save some memory)
Additionally, we patch the cardreader module to not ignore .bmp files on these machines.
+++ WORK IN PROGRESS+++
current status:
Requirements
Anycubic MEGA P with laser module
Benefits
The feature is not really useful imho, but it should finally work.
Configurations
--
Related Issues
--