Klicky Probe#461
Draft
sui77 wants to merge 2 commits intoknutwurst:masterfrom
Draft
Conversation
Owner
|
I like the idea and your implementation looks very solid. Glad you followed the guidelines and added a new build environment. :) However, I see some minor problems here:
My suggestion: I understand your intention to always get the firmware for your printer from this source, but I'm afraid that in this absolute special case a fork is the better choice. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Enables the use of a DIY magnetic mounted (aka "klicky") probe. It basically already works (preview video) but is still a work in progress. I need to refine STLs that I intend to publish on printables, write instructions and fine tune deploy&stow movements. I'd prefer to link to this well known repository instead of maintaining a fork, so if this comes into question I kindly ask you to do a first quick review before I go on.
Requirements
A klicky probe that consists of 4x1mm magnets, a limit switch and these STLs https://github.com/sui77/3d-printing/tree/master/klicky/stl that fit on a [MK4] carriage. Wiring is same as BLTOUCH except it doesn't utilize a servo.
Configurations
At this point I've added these environments: MEGA_TMC_KLICKY and MEGA_S_TMC_KLICKY