Repository navigation
Release 2.8.1: tick-based sampling, runtime_data, shared flow steps, CI cleanup - #156
Merged
Merged
Conversation
Every source-sensor update recomputed all derived values and also advanced the rolling histories, rain Kalman filter, wind smoothing, degree-day means, spike/drift buffers, alert debounce and solar-factor learning, so their behaviour depended on how often the station reported. That state now advances only on the 60 s tick; recomputes in between show the latest reading without storing it. The redundant built-in coordinator poll is removed. Drift detection now uses a real 72 h window and needs 24 h of data before judging a slope, so the diurnal cycle no longer reads as drift.
ci.yml and hacs.yml duplicated validate.yml's hassfest, HACS, lint and test jobs, so every push and PR ran them twice.
Replaces hass.data[DOMAIN]. Services now resolve coordinators from loaded entries, and setup auto-detection excludes the derived sensors of every configured prefix (it looked for a non-existent coordinator attribute, so only sensor.ws_* was skipped).
The two flows carried hand-maintained copies of the eight upload-credential steps and the indoor-room steps. The copies had drifted: setup hard-coded a different next-step list per step, so after Weathercloud it never asked for OWM Stations, Windy or CWOP credentials. Both flows now use one implementation driven by an ordered service table; step IDs and translations are unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Release 2.8.1: four follow-ups from the 2.8.0 review plus the version bump, one commit each.
validate.yml.ci.ymlandhacs.ymlduplicated its jobs.entry.runtime_datainstead ofhass.data[DOMAIN]. Also fixes setup offering a custom-prefix station's own sensors as sources.flow_steps.py). Fixes setup never asking for OWM Stations / Windy / CWOP credentials after Weathercloud. The options flow now trims and validates input like setup does.manifest.json/pyproject.tomland CHANGELOG section.Related Issue
None; follow-ups from the 2.8.0 code review.
How Has This Been Tested?
pytest tests/: 434 passed, including newtest_sampling.py,test_runtime_data.pyandtest_flow_steps.py.ruff check/ruff format --checkclean.Types of changes
Checklist: