Repository navigation
Release 2.8.0: correctness, robustness and accuracy fixes - #155
Merged
Merged
Conversation
…eview Fixes stuck-sensor detection (never fired), degree-day season totals, service crashes without entry_id, FWI double-drying and midnight timing, the pressure-trend window resetting on restart, irrigation score ignoring today's rain, WU/PWS daily rain, double hourly-forecast blending, ET0 timing, and river flow units (L/s). Also: entry-scoped background tasks that survive errors, per-entry Repairs issues, API keys kept out of logs, HA's shared HTTP session, forecast push to frontend cards, and frost point / AQI / gust calibration / unit conversion accuracy fixes. Adds regression tests and lints tests/ and scripts/ in CI. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NDoSoikPAM68kMZh8WRUHf
kmich
pushed a commit
that referenced
this pull request
Sep 25, 2026
Release 2.8.0: correctness, robustness and accuracy fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes from a full code review, released as 2.8.0. The full list is in
CHANGELOG.md.Confirmed bugs
reset_rain_baseline,reset_learning_stateandexport_learning_stateraisedAttributeErrorwhen called withoutentry_id. The event platform had stored a plain dict inhass.data[DOMAIN]; event entities now live on the coordinator.fwi_indices()helper).dailyraininwas the rolling 24 h total; it is now rain since local midnight.Robustness and security
_start_periodic/_start_once. A failed run is logged and retried, and every task is cancelled on unload.async_remove_entry).ClientResponseError, and error messages are scrubbed.Accuracy
h00for 100 % humidity and adds the since-midnight rain fieldP.Related Issue
None. These came out of a repository-wide code review rather than a reported issue.
Motivation and Context
Several derived sensors were silently wrong (degree-day seasons, FWI, river flow, irrigation score, stuck detection), and three services crashed. A few changes alter sensor values users may compare against thresholds:
How Has This Been Tested?
pytest tests/on Python 3.12 with Home Assistant 2024.12.5: 420 passed. This includes 27 new regression tests intests/test_review_fixes.pyandtests/test_uploaders.pycovering each fix above.ruff checkandruff format --checkpass oncustom_components/,tests/andscripts/.scripts/validate_dashboard_entities.pypasses, and the manifest/pyproject versions match.Types of changes
Checklist:
Not in this PR: splitting
_computeinto tick-driven accumulation and idempotent derivation, de-duplicating the config/options flow steps, moving toentry.runtime_data, using HA-native unit conversion, and the CI workflow duplication.