Repository navigation
Fix Penman-Monteith daily solar radiation input (#152) - #153
Merged
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #152.
et0_penman_monteith()expects solar radiation as a 24-hour daily mean in W/m², but the coordinator was passing the weather station's instantaneous reading. Because the algorithm converts that value to MJ/m²/day, a noon reading could be treated as though it applied for 24 hours and substantially inflate ET₀.Changes
previous_day_whm2 / 24instead of instantaneous solar W/m².This intentionally takes the strict FAO-56 path rather than extrapolating a partial day's solar curve, avoiding unstable dawn estimates and errors after downtime/restarts.