fix: dispatch mouseLeave to the tracked widget on chart leave - #848
Open
NemeZZiZZ wants to merge 1 commit into
Open
fix: dispatch mouseLeave to the tracked widget on chart leave#848NemeZZiZZ wants to merge 1 commit into
NemeZZiZZ wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Event.mouseLeaveEvent(the chart-level leave, fired from the container'smouseleave) clears the crosshair but never tells the tracked widget that the pointer left:Meanwhile
mouseMoveEventmaintains_mouseMoveTriggerWidgetInfoand dispatchesmouseEnterEvent/mouseLeaveEventto widgets as the pointer moves between them (Event.ts:352-356) — but on leaving the whole chart, that machinery is skipped.Impact
SeparatorWidget._mouseLeaveEventis the only place that restores the separator's background totransparent. Hover a pane separator and move the cursor out of the chart: the separator stays highlighted._mouseMoveTriggerWidgetInfoalso goes stale, so re-entering the same widget does not re-firemouseEnterEvent(the widget still believes the pointer is inside).Fix
Before clearing the crosshair, dispatch
mouseLeaveEventto the tracked widget (with a widget-local event, via_makeWidgetEvent) and reset_mouseMoveTriggerWidgetInfo— mirroring the move path. The method now accepts the compat eventEventHandleralready passes to it.