fix: skip y-axis band when selected overlay has no point values - #845
Open
NemeZZiZZ wants to merge 1 commit into
Open
fix: skip y-axis band when selected overlay has no point values#845NemeZZiZZ wants to merge 1 commit into
NemeZZiZZ wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
OverlayYAxisViewpaints the selected overlay's band rect fromtopY/bottomY, which start asNumber.MAX_SAFE_INTEGER/Number.MIN_SAFE_INTEGERand are updated only for points that carry a numericvalue:For an overlay whose points carry only
timestamp(e.g.verticalSegment,verticalRayLine) created programmatically —createOverlay({ name: 'verticalSegment', points: [{ timestamp: a }, { timestamp: b }] })— and then selected by click, no point has avalue, so the rect is emitted withy ≈ 9e15andheight ≈ -1.8e16: a fill covering the entire y-axis widget.(UI drawing is not affected —
_coordinateToPointalways setsvaluethere; the trigger is programmatic points withoutvalue, plus selection, since the band renders only for the clicked overlay.)Fix
Emit the band only when at least one point actually contributed:
topY <= bottomYis true iff the loop updated the sentinels. One condition added.