Skip to content

fix: restore missing window sum in CR indicator #842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NemeZZiZZ wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: restore missing window sum in CR indicator #842

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions src/extension/indicator/currentRatio.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,8 @@ const currentRatio: IndicatorTemplate<Cr, number> = {
const ma3List: number[] = []
let ma4Sum = 0
const ma4List: number[] = []
let highSubSum = 0
let preMidSubSum = 0
const result: Cr[] = []
dataList.forEach((kLineData, i) => {
const cr: Cr = {}
Expand All @@ -73,9 +75,19 @@ const currentRatio: IndicatorTemplate<Cr, number> = {

const preMidSubLow = Math.max(0, prevMid - kLineData.low)

highSubSum += highSubPreMid
preMidSubSum += preMidSubLow
if (i >= params[0]) {
const outData = dataList[i - params[0]]
const outPrevData = dataList[i - params[0] - 1] ?? outData
const outPrevMid = (outPrevData.high + outPrevData.low) / 2
highSubSum -= Math.max(0, outData.high - outPrevMid)
preMidSubSum -= Math.max(0, outPrevMid - outData.low)
}

if (i >= params[0] - 1) {
if (preMidSubLow !== 0) {
cr.cr = (highSubPreMid / preMidSubLow) * 100
if (preMidSubSum !== 0) {
cr.cr = (highSubSum / preMidSubSum) * 100
} else {
cr.cr = 0
}
Expand Down