fix: guard i18n against unregistered locale - #841
Open
NemeZZiZZ wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
i18n()indexes the locale registry without a guard:Only
en-USandzh-CNare registered by default, andStore.setLocaleaccepts any string without validation. Soinit(el, { locale: 'zh-TW' })— or any typo — throwsTypeError: Cannot read properties of undefinedat the first tooltip render (CandleTooltipView.ts). The exception escapes from a canvas animation-frame callback (which hastry/finallybut nocatch), leaving the frame half-drawn and the chart effectively broken from init.Verified by execution against the real source:
i18n('indicator.tooltip.open', 'zh-TW')→ TypeError.Fix
Two lines of defense:
i18n()never throws:locales[locale]?.[key] ?? key— unknown locale degrades to the key itself, same as an unknown key already does.Store.setLocale()warns and falls back toen-USwhen the locale is not registered, so the chart still renders readable strings instead of raw keys.registerLocalewas already defensive ({ ...locales[locale], ...ls }); this makes the read side match.