fix: compare indicator figures by value in shouldUpdate - #839
Open
NemeZZiZZ wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Default
Indicator.shouldUpdatecomparesfiguresby reference:override()builds_prevIndicatorviaclone()(typeChecks.ts— recursive deep copy), soprev.figuresis always a different array instance thancurrent.figures. The reference comparison is therefore unconditionally true, makingcalc === true— and sincedraw = calc || …, alsodraw === true— on everyoverrideIndicatorcall.Verified by execution against the real source (Node, verbatim
Indicator.ts+typeChecks.ts): a no-opoverrideIndicator({ id })returnscalc: true, and so doesoverrideIndicator({ id, visible: false }).Impact
Any
overrideIndicator— togglingvisible, changingzLevel, moving to another pane, restyling — triggers a fullcalc(dataList, indicator)over the entire history plusregenerateFiguresand a full layout, where a redraw would suffice. On 50k bars with several indicators this is hundreds of milliseconds of pure waste per call.Fix
Compare
figuresby value, the same waycalcParamson the same line already is:One line.
figuresarrays are small (a handful of figure descriptors), so the stringify cost is negligible against a full indicator recalc.