Skip to content

[WIP]Hopscotch concurrent map #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
prototype2904 wants to merge 23 commits into
base: master
Choose a base branch
from
Open

[WIP]Hopscotch concurrent map #106

Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
e8590df
hopscotch plus some tests
prototype2904 Dec 26, 2017
8f6e40a
Добавление namespace
Dec 27, 2017
de07dda
New version
LeoSko Dec 27, 2017
78e476c
Уход от pthreads
Dec 28, 2017
6547d7d
Добавлен метод get. Более-менее стабильная версия.
Dec 29, 2017
45192b7
Merge pull request #1 from prototype2904/roma
Dec 30, 2017
c87179d
Trying to add tests
Jan 4, 2018
72c6874
Gonna add methods
Jan 8, 2018
fa16332
Project test
Jan 8, 2018
a53dc21
contains, erase, insert, insert_with, update, emplace, find
Jan 8, 2018
b702daa
erase, erase_with
Dron642 Jan 8, 2018
8a90778
get with cmp, simple insert
Jan 8, 2018
bd37015
Merge branch 'master' of https://github.com/prototype2903/libcds
Jan 8, 2018
c693dee
find
prototype2904 Jan 8, 2018
ae1c78b
update update :)
Jan 8, 2018
f2a9b0e
Merge branch 'master' of https://github.com/prototype2904/libcds
Jan 8, 2018
7e9b106
fix
prototype2904 Jan 8, 2018
4ab51d9
Fixing tests
Jan 8, 2018
ec6ddfd
Merge branch 'master' of https://github.com/prototype2904/libcds
Jan 8, 2018
536b8a8
less errors maybe?
Jan 10, 2018
5bde49d
some errors correction
Dron642 Jan 10, 2018
330235c
Copied Cuckoo Map/Set with new name to setup hierarchy
Jan 13, 2018
7375489
some algorithm corrections
Dron642 Jan 14, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions cds/container/hopscotch_hashmap.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,8 @@ namespace cds {
template <typename K>
bool contains(K const& key)
{
return get(key, [=](K const& one, K const& two) { return one != two; }) != NULL;
DATA data = get(key);

@LeoSko LeoSko Jan 10, 2018

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@khizmax, почему-то не хочет компилировать на этом моменте, второй день понять не можем почему, есть идеи?
MSVC: d:\sources\libcds\cds\container\hopscotch_hashmap.h(128): error C2672: 'cds::container::hopscotch_hashmap<cds_test::striped_map_fixture::key_type,cds_test::striped_map_fixture::value_type>::get': no matching overloaded function found

@khizmax khizmax Jan 10, 2018

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Во-первых, надо просто убрать = из [=], он тут не нужен:
return get(key, [](K const& one, K const& two) { return one != two; }) != nullptr;
Вторая причина - в template-параметре K функции: если этот тип отличен от template-параметра KEY класса, то конечно же такая лямбда не подойдет.

return data != NULL;
}

/// Checks whether the map contains \p key using \p pred predicate for searching
Expand Down Expand Up @@ -161,29 +162,29 @@ namespace cds {
{
DATA data = get(key, [=](K const& one, K const& two) { return one != two; });
f(data);
return *data != NULL;
return data != NULL;
}

template <typename K, typename Predicate>
bool find(K const& key, Predicate pred)
{
DATA data = get(key, pred);
return *data != NULL;
return data != NULL;
}

template <typename K>
bool find(K const& key)
{
DATA data = get(key, [=](K const& one, K const& two) { return one != two; });
return *data != NULL;
return data != NULL;
}

template <typename K, typename Predicate, typename Func>
bool find_with(K const& key, Predicate pred, Func f)
{
DATA data = get(key, [=](K const& one, K const& two) { return one != two; });
f(data);
return *data != NULL;
return data != NULL;
}

/// For key \p key inserts data of type \ref value_type constructed with <tt>std::forward<Args>(args)...</tt>
Expand Down