Skip to content

Write points fix - #15

Closed
will-moore wants to merge 2 commits into
kevinyamauchi:mainfrom
will-moore:write_points_fix
Closed

Write points fix#15
will-moore wants to merge 2 commits into
kevinyamauchi:mainfrom
will-moore:write_points_fix

Conversation

@will-moore

@will-moore will-moore commented Mar 14, 2023

Copy link
Copy Markdown
Contributor

This unifies write_table_regions() and write_table_points() etc to all use the fixes that I'd previously only applied to write_table_regions().

I noticed that write_table_circles() was using @type:

table_group.attrs["@type"]

but everywhere else this was simply table_group.attrs["type"]. This will now use type everywhere.

@will-moore

Copy link
Copy Markdown
Contributor Author

I realise this is used by openssbd/bdz#3 and contains useful fixes, so re-opening...
(although I understand that the NGFF tables spec is still undecided and all may change once that is finalised)

@will-moore will-moore reopened this Jun 22, 2023
@will-moore will-moore closed this Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant