Loosen up some things to allow vcrpy to work with niquests#980
Loosen up some things to allow vcrpy to work with niquests#980ionelmc wants to merge 2 commits intokevin1024:masterfrom
Conversation
|
@kevin1024 hey, can you approve workflows? |
|
Done
…-------- Original Message --------
On Tuesday, 03/10/26 at 07:06 Ionel Cristian Mărieș ***@***.***> wrote:
ionelmc left a comment [(kevin1024/vcrpy#980)](#980 (comment))
***@***.***(https://github.com/kevin1024) hey, can you approve workflows?
—
Reply to this email directly, [view it on GitHub](#980 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AAAFE24IH4GJ6VP6UBFWUX34P7ZMTAVCNFSM6AAAAACWMCLHC6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DAMZQGU4DANBWGE).
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
ionelmc
force-pushed
the
niquests-support
branch
from
a3e4c8f to
a60625f
Compare
|
@kevin1024 hey can you approve it again? Seems I forgot to install precommit hooks 🙈 |
|
You got it. Thanks for working on this. |
|
@kevin1024 looks like everything passes, feel free to review. |
|
So I've tried this in async mode, support for it' is a bit hairy to solve. Without async support it just errors out (no hangs or really bad stuff). My suggestion is to get this released and I'll follow up later with another pr for async support (not really my cup of tea, so I expect there will be a lot of pain to get async support). |
|
@kevin1024 hey can you take a look at this? I know it doesn't have async support but my plan for that is to come with a follow up PR with more changes (a completely new and independent niquests stub that doesn't deal with urllib at all). If I'd have them here I'd have a huge PR that I doubt you'd want to even look at. Anyway, synchronous mode is working with this, and these changes are still needed since installing urllib3-future pretends it's urllib3. Can we get these released meanwhile? |
|
@ionelmc I'm interested in using this update to support niquests in my project and wanted to know if there had been any updates or new blocks that have come up. Is there anything I can do to help move this forward? Thanks! |
|
@AL-Troy don't think so, it's up to @kevin1024 to review this, or at least approve some workflows. Feel free to use my branch, I won't delete it. |
|
Workflows approved! |
|
I swear will have some more time for vcr soon! |
3 participants
No description provided.