[Security] Fix SSE injection in EventStream and URL param cache decode bug - #765
Open
sdogruyol wants to merge 2 commits into
Open
[Security] Fix SSE injection in EventStream and URL param cache decode bug#765sdogruyol wants to merge 2 commits into
sdogruyol wants to merge 2 commits into
Conversation
Reject CR/LF in event/id and normalize line breaks in data/comment so untrusted values cannot forge SSE fields.
Member
Author
|
The Windows CI failure is unrelated on Crystal 1.16.3 😐 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses a security issue in Kemal's Server-Sent Events support, plus a related URL params caching bug.
Kemal::EventStreameventandid(ArgumentError)dataandcommentso untrusted input cannot forge SSE fieldsParamParsernow owns a copy of the params hash)Huge thanks to @hahwul for the responsible disclosure and detailed report 🙏