feat(systemextensionsctl): add functionality#597
feat(systemextensionsctl): add functionality#597georgettica wants to merge 15 commits intokellyjonbrazil:devfrom
Conversation
|
test failed on ubuntu even though this was only set to darwin? |
|
I just had to change the base branch to |
|
Oops, didn't check that :/ |
|
On my side I am ready to merge, if tests pass (and they did) |
|
Would be good to have some tests before merging, if possible. |
|
legitimate bug in code, caught by tests. need to mull it over until I fix it, or if you know how to resolve the bug quickly I can just do as you suggest |
|
woot woot! tests are passing! |
|
For me having this as json is a huge step forward, so any schema changes are welcome |
|
tests have passed! feel free to review again @kellyjonbrazil |
|
Hi @georgettica - sorry I've been traveling quite a bit the past few months. I'll take a closer look soon and start working on wrapping up the next release. |
|
No rush or problem, just thought it was lost between the cracks |
kellyjonbrazil
left a comment
kellyjonbrazil
left a comment
There was a problem hiding this comment.
Thanks for the contribution! Some items to address.
There was a problem hiding this comment.
Make sure to add the new parser to lib.py.
| Compatibility: | ||
|
|
||
| macOS |
|
|
||
| macOS | ||
|
|
||
| Example: |
| return category, description | ||
|
|
||
|
|
||
| def parse_entry(line: str, headers: List[str]) -> Optional[Dict[str, Any]]: |
There was a problem hiding this comment.
All of these function names should be preceeded by an underscore. (e.g. _parse_entry) Only parse should not start with an underscore. This will ensure the documentation is generated correctly.
|
Will address all of these issues soon. Also, they all seem small, which is great |
|
I think everything is ready to merge on my part, and PR is moving forward |
|
I don't see the changes yet. Did you push them to the branch? |
|
Yeah, I see there are no changes now, I'll test this soon and come vack |
|
@georgettica checking back in on this PR. I don't see any commits after Nov 20th. Could you update the branch with the changes? Thanks! |
2 participants
No description provided.