Skip to content

refactor: simplify exclusive timeZone/utcOffset runtime check #1067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Gdhanush-13 wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −7
Open

refactor: simplify exclusive timeZone/utcOffset runtime check #1067

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions src/job.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,13 +93,12 @@ export class CronJob<OC extends CronOnCompleteCommand | null = null, C = null> {
throw new ExclusiveParametersError('timeZone', 'utcOffset');
}

if (timeZone != null) {
this.cronTime = new CronTime(cronTime, timeZone, null);
} else if (utcOffset != null) {
this.cronTime = new CronTime(cronTime, null, utcOffset);
} else {
this.cronTime = new CronTime(cronTime, timeZone, utcOffset);
}
// After the exclusive check above, at most one of timeZone or utcOffset
// is non-null — pass the active one and null for the other.
this.cronTime =
timeZone != null
? new CronTime(cronTime, timeZone, null)
: new CronTime(cronTime, null, utcOffset ?? null);

if (unrefTimeout != null) {
this.unrefTimeout = unrefTimeout;
Expand Down
Loading