Use Buffer.from explicitly when using zlib#16
Merged
kazumatu981 merged 1 commit intokazumatu981:mainfrom Jun 21, 2024
Merged
Conversation
… to compress the diagram
kazumatu981
added a commit
that referenced
this pull request
Jun 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
Using
markdown-it-krokiinside an obsidian marp plugin fails to compress the diagram properly and produces 400 error on krokiDesired Result
Diagrams show up properly on obsidian marp plugin
Cause:
To compile obsidian plugins for use in both mobile and desktop, the plugins needs to be packed for web only.
The packed
zlib-browserifyis using pako which does not support compressing strings, the proposed change solves that issue by adding Buffer.from.Further information:
the default browserify buffer module does not support base64url, so I'm using an alternative from feross (specifically pr 314)
I didn't want to add extra noise by adding more changes to this plugin by modifying the base64url as well.