Stabilize daemon utxo propagation test#1003
Merged
michaelsutton merged 1 commit intoMay 14, 2026
Merged
Conversation
ListeningClient uses the multi-listener gRPC path, where start_notify awaits the local listener mutation but upstream server-side registration is applied asynchronously by the notifier subscriber task. The test subscribed and immediately mined, so CI could start mining before one of the server-side notification registrations was active, causing the matching notification to be missed and the test to time out. Warm up the multi-listener clients during the initial mining batch, wait until both listeners observe the final block and virtual DAA notifications, and drain old block/DAA events before each submitted block so mine_block waits only on fresh notifications.
michaelsutton
changed the title
Contributor
Author
|
Replaces #992 |
coderofstuff
approved these changes
May 14, 2026
someone235
approved these changes
May 14, 2026
Contributor
|
@michaelsutton — re your audit ask: your diagnosis is grounded in source. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The daemon UTXO propagation test could start mining before all multi-listener subscriptions were fully registered server-side. When that happened, a listener could miss the event it later waited for, causing an intermittent timeout despite the block itself being processed.
This PR makes the test wait for the initial notification batch to reach all relevant listeners and drains stale events before entering the per-block mining/wait loop. This keeps the test’s notification expectations aligned with the actual listener registration state.