Use prow/GCB for automated image builds rather than GitHub Actions#2
Closed
kahirokunn wants to merge 1 commit intomainfrom
Closed
Use prow/GCB for automated image builds rather than GitHub Actions#2kahirokunn wants to merge 1 commit intomainfrom
kahirokunn wants to merge 1 commit intomainfrom
Conversation
b4811a3 to
0debfed
Compare
6210e94 to
0884b3b
Compare
There was a problem hiding this comment.
Pull request overview
Moves automated image builds away from GitHub Actions and toward Kubernetes test-infra (prow/GCB), updating the release process accordingly.
Changes:
- Add a
cloudbuild.yamlthat runsmake release-stagingto build/push multi-arch plugin images to the k8s staging registry. - Add a
release-stagingMakefile target to build/push all plugin images in a loop. - Update release documentation and add a GitHub issue template; remove the GitHub Actions tag-based release workflow.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
cloudbuild.yaml |
New Cloud Build config to build/push images via GCB. |
Makefile |
Adds release-staging and plugin discovery to build/push all plugin images. |
RELEASE.md |
Updates release flow to staging + kpromo-based promotion to registry.k8s.io. |
.github/workflows/release.yml |
Removes the GitHub Actions-based release pipeline. |
.github/ISSUE_TEMPLATE/NEW_RELEASE.md |
Adds a release checklist issue template aligned to the new process. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
0884b3b to
56f5098
Compare
Signed-off-by: kahirokunn <okinakahiro@gmail.com>
56f5098 to
2cd5253
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Switch the plugin image release pipeline from a GitHub Actions workflow that pushed to GHCR over to the standard k8s SIG release path (GCB postsubmit →
k8s-staging-images→kpromo→registry.k8s.io).Changes
cloudbuild.yamlinvoked by the test-infra postsubmit.make release-stagingtarget that builds/pushes everyplugins/*/cmd/pluginvia the existingdocker-buildxtarget..github/workflows/release.yml.RELEASE.mdand add.github/ISSUE_TEMPLATE/NEW_RELEASE.mdto describe the new tag → staging → promote flow.Related PRs
post-cluster-inventory-api-push-imagesprow job.A follow-up PR will add the promotion manifest under
registry.k8s.io/images/k8s-staging-cluster-inventory-api/.Verification
Verified
release-stagingagainst a personal GHCR namespace: