Feature/reduce gem size#486
Open
frezbo wants to merge 1 commit intok1LoW:mainfrom
Open
Conversation
Signed-off-by: Noel Georgi <git@frezbo.com>
Owner
|
Hi @frezbo Thank you for you commit!! I have one question. Why do you want to reduse the gem dependencies ? I think it's more important to be easier when someone adds a new resource than the size of the gem. |
Author
|
@k1LoW Yes I agree to the ease of adding a new gem, but the existing code also means that any gem project depending on |
Owner
|
@frezbo Thank you ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This tries to reduce the gem dependencies to only what is being used.