#443: SSM Parameters pagination issue, replaced with get_parameter AP…#481
Open
cthulhu wants to merge 3 commits intok1LoW:mainfrom
Open
#443: SSM Parameters pagination issue, replaced with get_parameter AP…#481cthulhu wants to merge 3 commits intok1LoW:mainfrom
cthulhu wants to merge 3 commits intok1LoW:mainfrom
Conversation
Owner
|
Hi @cthulhu . Thank you for your pull request !!! |
tozonaran
approved these changes
Aug 19, 2019
Author
|
@k1LoW Indeed, however, the code would become a bit more complex if you would iterate over the params. Besides, API has an endpoint to fetch 1 param info. Perhaps we could go with that? Otherwise, I can change it but it will take some time. |
Owner
|
I care about the difference in interface.
Thank you ! |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced ssm parameters describe API call with get_parameter call to fix pagination issue.
Fixed specs and changed a bit behavior of the spec for ssm. It has a few values less now because of the differences in APIs. However, it also has value now. So we can test against it if it is not encrypted.