Skip to content

#443: SSM Parameters pagination issue, replaced with get_parameter AP…#481

Open
cthulhu wants to merge 3 commits intok1LoW:mainfrom
cthulhu:ssm-pagination-443
Open

#443: SSM Parameters pagination issue, replaced with get_parameter AP…#481
cthulhu wants to merge 3 commits intok1LoW:mainfrom
cthulhu:ssm-pagination-443

Conversation

@cthulhu
Copy link
Copy Markdown

@cthulhu cthulhu commented Aug 6, 2019

Replaced ssm parameters describe API call with get_parameter call to fix pagination issue.

Fixed specs and changed a bit behavior of the spec for ssm. It has a few values less now because of the differences in APIs. However, it also has value now. So we can test against it if it is not encrypted.

@k1LoW
Copy link
Copy Markdown
Owner

k1LoW commented Aug 17, 2019

Hi @cthulhu . Thank you for your pull request !!!
According to the documentation, describe_parameters seems to be able to get all parameters using next_token .

@cthulhu
Copy link
Copy Markdown
Author

cthulhu commented Aug 21, 2019

@k1LoW Indeed, however, the code would become a bit more complex if you would iterate over the params. Besides, API has an endpoint to fetch 1 param info. Perhaps we could go with that? Otherwise, I can change it but it will take some time.

@k1LoW
Copy link
Copy Markdown
Owner

k1LoW commented Aug 22, 2019

@cthulhu

I care about the difference in interface.

It has a few values less now because of the differences in APIs

Otherwise, I can change it but it will take some time.

Thank you !

@anjo-swe
Copy link
Copy Markdown
Contributor

@k1LoW @cthulhu create a new PR (#583) that uses pagination

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants