This repository was archived by the owner on Aug 11, 2025. It is now read-only.
fix: add Close method#1
Merged
Merged
Conversation
This enable flushing correctly the metrics
|
Without having much context here, would it make more sense to throw this PR up on the Shopify repo? Once we fork it, we own it. If we get them to merge this change, they benefit and we don't have to maintain it |
jjacobskind
approved these changes
May 13, 2024
jjacobskind
left a comment
jjacobskind
left a comment
There was a problem hiding this comment.
Thanks for sharing the context that @mtwstudios threw up a PR a while back that never got merged. I think it's worth reminding the Shopify folks about the PR, since it's been two years
Approving though, in case they don't address it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enable flushing correctly the metrics
By default, metrics are buffered and sent to Datadog every 100ms
If we are for example shutting down an app, some metrics might be lost
By Closing it properly, we ensure every metrics will be actually sent