-
Notifications
You must be signed in to change notification settings - Fork 41
feat(observability): OpenTelemetry golden-signals middleware #998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
knutties
wants to merge
47
commits into
main
Choose a base branch
from
feat/otel-golden-signals-middleware
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 26 commits
Commits
Show all changes
47 commits
Select commit
Hold shift + click to select a range
9d267e6
docs(spec): OpenTelemetry golden-signals middleware design
knutties ee4d70b
docs(plan): OpenTelemetry golden-signals middleware implementation plan
knutties 1255c16
build: add opentelemetry deps to workspace
knutties b50e36d
build: enable tokio_unstable workspace-wide
knutties 7db5239
build(service_utils): enable opentelemetry deps
knutties 92b2f42
feat(observability): module skeleton
knutties b7483e7
feat(observability): config from env
knutties 4b1cc8b
feat(observability): http method normalization
knutties 33e67b8
feat(observability): MeterProvider with prometheus exporter
knutties 3bea122
feat(observability): route template extraction helper
knutties ea2e596
feat(observability): build OTel attributes for HTTP metrics
knutties c05be67
feat(observability): RAII guard for active_requests gauge
knutties ebc24d3
feat(observability): MetricsMiddleware records HTTP signals
knutties 73c35ee
feat(observability): /healthz /livez /readyz handlers
knutties e7bfadd
feat(observability): /metrics server on dedicated port
knutties f9518f0
feat(observability): db + redis pool saturation gauges
knutties ce50783
feat(observability): tokio runtime saturation gauges
knutties 43cafd8
feat: exclude /healthz /livez /readyz from auth checks
knutties 02113f1
feat: wire observability into main binary
knutties 267a33c
test(observability): end-to-end integration
knutties dae4266
test(observability): cardinality regression budget
knutties 77dc30b
docs: note metrics endpoints and tokio_unstable build flag
knutties c62b439
fix(observability): graceful degradation on init failure (review fix 1)
knutties 60c0a30
fix(observability): __static__ sentinel, extract_route_from_response,…
knutties e71a4d6
fix(observability): merge OTEL_RESOURCE_ATTRIBUTES; document OTLP env…
knutties 1bca586
docs(README): drop spec link from observability section
knutties faa7937
fix(observability): graceful OTLP degradation + gRPC protocol warning…
knutties e98e978
chore(deps): drop opentelemetry-semantic-conventions dep (item 2)
knutties 6e93548
chore(observability): remove dead code stubs (items 4, 5, 6)
knutties 1011088
fix(observability): expose redis.client.connections.connected gauge (…
knutties 044c174
refactor(observability): inject env source into ObservabilityConfig::…
knutties 3728b0b
fix(observability): mount health endpoints without empty-prefix scope
knutties 9a58318
chore(deps): regenerate Cargo.lock after dropping opentelemetry-seman…
knutties e077a72
style: apply rustfmt to PR-touched files
knutties e9e4fea
fix(observability): clippy lints flagged by CI
knutties 8ed83db
fix(observability): clippy async_yields_async in integration tests
knutties 39b18c8
fix(observability): IPv6-safe metrics bind, percent-decoded OTEL reso…
knutties 0f1c796
chore(observability): doc fixes and small style/semconv tweaks
knutties 7c7bf13
fix(observability): detach metrics server lifetime from main API server
knutties 8fb3096
refactor(observability): DRY env key names with FromStr-based parse h…
knutties 940e755
refactor(observability): drop get_str — collapse into parse_or_default
knutties cb5f8ce
refactor(observability): introduce crate-private EnvSource marker trait
knutties 80ee392
refactor(observability): collapse normalize_method to a single macro
knutties fabdf19
refactor(observability): read Handle::metrics() directly; drop tokio-…
knutties dc75c9b
chore(observability): remove /healthz /livez /readyz endpoints
knutties 3269f9a
docs(observability): note post-implementation deviations from plan/spec
knutties 7d6f51b
test(observability): move tokio-runtime check to integration test
knutties File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| # Required by tokio-metrics for runtime instrumentation. Affects all | ||
| # crates in the workspace; only the saturation::tokio_runtime module | ||
| # consumes the additional APIs that this flag unlocks. | ||
| [build] | ||
| rustflags = ["--cfg", "tokio_unstable"] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a language identifier to the code fence.
markdownlint (MD040) flags this fence. Use
bashso thecurlsnippet gets syntax highlighting and the lint passes.📝 Suggested change
📝 Committable suggestion
🧰 Tools
🪛 markdownlint-cli2 (0.22.1)
[warning] 157-157: Fenced code blocks should have a language specified
(MD040, fenced-code-language)
🤖 Prompt for AI Agents