Skip to content

refactor: remove unnecessary clone from eval logic #857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ayushjain17 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor: remove unnecessary clone from eval logic #857

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

21 changes: 13 additions & 8 deletions clients/java/bindings/src/main/kotlin/uniffi/superposition_client/superposition_client.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,13 +37,15 @@ import uniffi.superposition_types.Config
import uniffi.superposition_types.Context
import uniffi.superposition_types.DimensionInfo
import uniffi.superposition_types.ExperimentStatusType
import uniffi.superposition_types.ExtendedMap
import uniffi.superposition_types.FfiConverterTypeBucket
import uniffi.superposition_types.FfiConverterTypeBuckets
import uniffi.superposition_types.FfiConverterTypeCondition
import uniffi.superposition_types.FfiConverterTypeConfig
import uniffi.superposition_types.FfiConverterTypeContext
import uniffi.superposition_types.FfiConverterTypeDimensionInfo
import uniffi.superposition_types.FfiConverterTypeExperimentStatusType
import uniffi.superposition_types.FfiConverterTypeExtendedMap
import uniffi.superposition_types.FfiConverterTypeGroupType
import uniffi.superposition_types.FfiConverterTypeMergeStrategy
import uniffi.superposition_types.FfiConverterTypeOverrides
Expand All @@ -61,6 +63,7 @@ import uniffi.superposition_types.RustBuffer as RustBufferConfig
import uniffi.superposition_types.RustBuffer as RustBufferContext
import uniffi.superposition_types.RustBuffer as RustBufferDimensionInfo
import uniffi.superposition_types.RustBuffer as RustBufferExperimentStatusType
import uniffi.superposition_types.RustBuffer as RustBufferExtendedMap
import uniffi.superposition_types.RustBuffer as RustBufferGroupType
import uniffi.superposition_types.RustBuffer as RustBufferMergeStrategy
import uniffi.superposition_types.RustBuffer as RustBufferOverrides
Expand Down Expand Up @@ -824,9 +827,9 @@ internal interface UniffiLib : Library {
}

// FFI functions
fun uniffi_superposition_core_fn_func_ffi_eval_config(`defaultConfig`: RustBuffer.ByValue,`contexts`: RustBuffer.ByValue,`overrides`: RustBuffer.ByValue,`dimensions`: RustBuffer.ByValue,`queryData`: RustBuffer.ByValue,`mergeStrategy`: RustBufferMergeStrategy.ByValue,`filterPrefixes`: RustBuffer.ByValue,`experimentation`: RustBuffer.ByValue,uniffi_out_err: UniffiRustCallStatus,
fun uniffi_superposition_core_fn_func_ffi_eval_config(`defaultConfig`: RustBufferExtendedMap.ByValue,`contexts`: RustBuffer.ByValue,`overrides`: RustBuffer.ByValue,`dimensions`: RustBuffer.ByValue,`queryData`: RustBuffer.ByValue,`mergeStrategy`: RustBufferMergeStrategy.ByValue,`filterPrefixes`: RustBuffer.ByValue,`experimentation`: RustBuffer.ByValue,uniffi_out_err: UniffiRustCallStatus,
): RustBuffer.ByValue
fun uniffi_superposition_core_fn_func_ffi_eval_config_with_reasoning(`defaultConfig`: RustBuffer.ByValue,`contexts`: RustBuffer.ByValue,`overrides`: RustBuffer.ByValue,`dimensions`: RustBuffer.ByValue,`queryData`: RustBuffer.ByValue,`mergeStrategy`: RustBufferMergeStrategy.ByValue,`filterPrefixes`: RustBuffer.ByValue,`experimentation`: RustBuffer.ByValue,uniffi_out_err: UniffiRustCallStatus,
fun uniffi_superposition_core_fn_func_ffi_eval_config_with_reasoning(`defaultConfig`: RustBufferExtendedMap.ByValue,`contexts`: RustBuffer.ByValue,`overrides`: RustBuffer.ByValue,`dimensions`: RustBuffer.ByValue,`queryData`: RustBuffer.ByValue,`mergeStrategy`: RustBufferMergeStrategy.ByValue,`filterPrefixes`: RustBuffer.ByValue,`experimentation`: RustBuffer.ByValue,uniffi_out_err: UniffiRustCallStatus,
): RustBuffer.ByValue
fun uniffi_superposition_core_fn_func_ffi_get_applicable_variants(`eargs`: RustBuffer.ByValue,`dimensionsInfo`: RustBuffer.ByValue,`queryData`: RustBuffer.ByValue,`prefix`: RustBuffer.ByValue,uniffi_out_err: UniffiRustCallStatus,
): RustBuffer.ByValue
Expand Down Expand Up @@ -958,10 +961,10 @@ private fun uniffiCheckContractApiVersion(lib: IntegrityCheckingUniffiLib) {
}
@Suppress("UNUSED_PARAMETER")
private fun uniffiCheckApiChecksums(lib: IntegrityCheckingUniffiLib) {
if (lib.uniffi_superposition_core_checksum_func_ffi_eval_config() != 61169.toShort()) {
if (lib.uniffi_superposition_core_checksum_func_ffi_eval_config() != 40327.toShort()) {
throw RuntimeException("UniFFI API checksum mismatch: try cleaning and rebuilding your project")
}
if (lib.uniffi_superposition_core_checksum_func_ffi_eval_config_with_reasoning() != 47981.toShort()) {
if (lib.uniffi_superposition_core_checksum_func_ffi_eval_config_with_reasoning() != 10312.toShort()) {
throw RuntimeException("UniFFI API checksum mismatch: try cleaning and rebuilding your project")
}
if (lib.uniffi_superposition_core_checksum_func_ffi_get_applicable_variants() != 58234.toShort()) {
Expand Down Expand Up @@ -1720,21 +1723,23 @@ public object FfiConverterMapStringTypeOverrides: FfiConverterRustBuffer<Map<kot



@Throws(OperationException::class) fun `ffiEvalConfig`(`defaultConfig`: Map<kotlin.String, kotlin.String>, `contexts`: List<Context>, `overrides`: Map<kotlin.String, Overrides>, `dimensions`: Map<kotlin.String, DimensionInfo>, `queryData`: Map<kotlin.String, kotlin.String>, `mergeStrategy`: MergeStrategy, `filterPrefixes`: List<kotlin.String>?, `experimentation`: ExperimentationArgs?): Map<kotlin.String, kotlin.String> {


@Throws(OperationException::class) fun `ffiEvalConfig`(`defaultConfig`: ExtendedMap, `contexts`: List<Context>, `overrides`: Map<kotlin.String, Overrides>, `dimensions`: Map<kotlin.String, DimensionInfo>, `queryData`: Map<kotlin.String, kotlin.String>, `mergeStrategy`: MergeStrategy, `filterPrefixes`: List<kotlin.String>?, `experimentation`: ExperimentationArgs?): Map<kotlin.String, kotlin.String> {
return FfiConverterMapStringString.lift(
uniffiRustCallWithError(OperationException) { _status ->
UniffiLib.INSTANCE.uniffi_superposition_core_fn_func_ffi_eval_config(
FfiConverterMapStringString.lower(`defaultConfig`),FfiConverterSequenceTypeContext.lower(`contexts`),FfiConverterMapStringTypeOverrides.lower(`overrides`),FfiConverterMapStringTypeDimensionInfo.lower(`dimensions`),FfiConverterMapStringString.lower(`queryData`),FfiConverterTypeMergeStrategy.lower(`mergeStrategy`),FfiConverterOptionalSequenceString.lower(`filterPrefixes`),FfiConverterOptionalTypeExperimentationArgs.lower(`experimentation`),_status)
FfiConverterTypeExtendedMap.lower(`defaultConfig`),FfiConverterSequenceTypeContext.lower(`contexts`),FfiConverterMapStringTypeOverrides.lower(`overrides`),FfiConverterMapStringTypeDimensionInfo.lower(`dimensions`),FfiConverterMapStringString.lower(`queryData`),FfiConverterTypeMergeStrategy.lower(`mergeStrategy`),FfiConverterOptionalSequenceString.lower(`filterPrefixes`),FfiConverterOptionalTypeExperimentationArgs.lower(`experimentation`),_status)
}
)
}


@Throws(OperationException::class) fun `ffiEvalConfigWithReasoning`(`defaultConfig`: Map<kotlin.String, kotlin.String>, `contexts`: List<Context>, `overrides`: Map<kotlin.String, Overrides>, `dimensions`: Map<kotlin.String, DimensionInfo>, `queryData`: Map<kotlin.String, kotlin.String>, `mergeStrategy`: MergeStrategy, `filterPrefixes`: List<kotlin.String>?, `experimentation`: ExperimentationArgs?): Map<kotlin.String, kotlin.String> {
@Throws(OperationException::class) fun `ffiEvalConfigWithReasoning`(`defaultConfig`: ExtendedMap, `contexts`: List<Context>, `overrides`: Map<kotlin.String, Overrides>, `dimensions`: Map<kotlin.String, DimensionInfo>, `queryData`: Map<kotlin.String, kotlin.String>, `mergeStrategy`: MergeStrategy, `filterPrefixes`: List<kotlin.String>?, `experimentation`: ExperimentationArgs?): Map<kotlin.String, kotlin.String> {
return FfiConverterMapStringString.lift(
uniffiRustCallWithError(OperationException) { _status ->
UniffiLib.INSTANCE.uniffi_superposition_core_fn_func_ffi_eval_config_with_reasoning(
FfiConverterMapStringString.lower(`defaultConfig`),FfiConverterSequenceTypeContext.lower(`contexts`),FfiConverterMapStringTypeOverrides.lower(`overrides`),FfiConverterMapStringTypeDimensionInfo.lower(`dimensions`),FfiConverterMapStringString.lower(`queryData`),FfiConverterTypeMergeStrategy.lower(`mergeStrategy`),FfiConverterOptionalSequenceString.lower(`filterPrefixes`),FfiConverterOptionalTypeExperimentationArgs.lower(`experimentation`),_status)
FfiConverterTypeExtendedMap.lower(`defaultConfig`),FfiConverterSequenceTypeContext.lower(`contexts`),FfiConverterMapStringTypeOverrides.lower(`overrides`),FfiConverterMapStringTypeDimensionInfo.lower(`dimensions`),FfiConverterMapStringString.lower(`queryData`),FfiConverterTypeMergeStrategy.lower(`mergeStrategy`),FfiConverterOptionalSequenceString.lower(`filterPrefixes`),FfiConverterOptionalTypeExperimentationArgs.lower(`experimentation`),_status)
}
)
}
Expand Down
25 changes: 15 additions & 10 deletions clients/python/bindings/superposition_bindings/superposition_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
from .superposition_types import Context
from .superposition_types import DimensionInfo
from .superposition_types import ExperimentStatusType
from .superposition_types import ExtendedMap
from .superposition_types import GroupType
from .superposition_types import MergeStrategy
from .superposition_types import Overrides
Expand All @@ -47,6 +48,7 @@
from .superposition_types import _UniffiConverterTypeContext
from .superposition_types import _UniffiConverterTypeDimensionInfo
from .superposition_types import _UniffiConverterTypeExperimentStatusType
from .superposition_types import _UniffiConverterTypeExtendedMap
from .superposition_types import _UniffiConverterTypeGroupType
from .superposition_types import _UniffiConverterTypeMergeStrategy
from .superposition_types import _UniffiConverterTypeOverrides
Expand All @@ -59,6 +61,7 @@
from .superposition_types import _UniffiRustBuffer as _UniffiRustBufferContext
from .superposition_types import _UniffiRustBuffer as _UniffiRustBufferDimensionInfo
from .superposition_types import _UniffiRustBuffer as _UniffiRustBufferExperimentStatusType
from .superposition_types import _UniffiRustBuffer as _UniffiRustBufferExtendedMap
from .superposition_types import _UniffiRustBuffer as _UniffiRustBufferGroupType
from .superposition_types import _UniffiRustBuffer as _UniffiRustBufferMergeStrategy
from .superposition_types import _UniffiRustBuffer as _UniffiRustBufferOverrides
Expand Down Expand Up @@ -495,9 +498,9 @@ def _uniffi_check_contract_api_version(lib):
raise InternalError("UniFFI contract version mismatch: try cleaning and rebuilding your project")

def _uniffi_check_api_checksums(lib):
if lib.uniffi_superposition_core_checksum_func_ffi_eval_config() != 61169:
if lib.uniffi_superposition_core_checksum_func_ffi_eval_config() != 40327:
raise InternalError("UniFFI API checksum mismatch: try cleaning and rebuilding your project")
if lib.uniffi_superposition_core_checksum_func_ffi_eval_config_with_reasoning() != 47981:
if lib.uniffi_superposition_core_checksum_func_ffi_eval_config_with_reasoning() != 10312:
raise InternalError("UniFFI API checksum mismatch: try cleaning and rebuilding your project")
if lib.uniffi_superposition_core_checksum_func_ffi_get_applicable_variants() != 58234:
raise InternalError("UniFFI API checksum mismatch: try cleaning and rebuilding your project")
Expand Down Expand Up @@ -610,7 +613,7 @@ class _UniffiForeignFutureStructVoid(ctypes.Structure):
_UNIFFI_FOREIGN_FUTURE_COMPLETE_VOID = ctypes.CFUNCTYPE(None,ctypes.c_uint64,_UniffiForeignFutureStructVoid,
)
_UniffiLib.uniffi_superposition_core_fn_func_ffi_eval_config.argtypes = (
_UniffiRustBuffer,
_UniffiRustBufferExtendedMap,
_UniffiRustBuffer,
_UniffiRustBuffer,
_UniffiRustBuffer,
Expand All @@ -622,7 +625,7 @@ class _UniffiForeignFutureStructVoid(ctypes.Structure):
)
_UniffiLib.uniffi_superposition_core_fn_func_ffi_eval_config.restype = _UniffiRustBuffer
_UniffiLib.uniffi_superposition_core_fn_func_ffi_eval_config_with_reasoning.argtypes = (
_UniffiRustBuffer,
_UniffiRustBufferExtendedMap,
_UniffiRustBuffer,
_UniffiRustBuffer,
_UniffiRustBuffer,
Expand Down Expand Up @@ -1552,14 +1555,16 @@ def read(cls, buf):

# External type Condition: `from .superposition_types import Condition`

# External type ExtendedMap: `from .superposition_types import ExtendedMap`

# External type Overrides: `from .superposition_types import Overrides`

# External type Variants: `from .superposition_types import Variants`

# Async support

def ffi_eval_config(default_config: "dict[str, str]",contexts: "typing.List[Context]",overrides: "dict[str, Overrides]",dimensions: "dict[str, DimensionInfo]",query_data: "dict[str, str]",merge_strategy: "MergeStrategy",filter_prefixes: "typing.Optional[typing.List[str]]",experimentation: "typing.Optional[ExperimentationArgs]") -> "dict[str, str]":
_UniffiConverterMapStringString.check_lower(default_config)
def ffi_eval_config(default_config: "ExtendedMap",contexts: "typing.List[Context]",overrides: "dict[str, Overrides]",dimensions: "dict[str, DimensionInfo]",query_data: "dict[str, str]",merge_strategy: "MergeStrategy",filter_prefixes: "typing.Optional[typing.List[str]]",experimentation: "typing.Optional[ExperimentationArgs]") -> "dict[str, str]":
_UniffiConverterTypeExtendedMap.check_lower(default_config)

_UniffiConverterSequenceTypeContext.check_lower(contexts)

Expand All @@ -1576,7 +1581,7 @@ def ffi_eval_config(default_config: "dict[str, str]",contexts: "typing.List[Cont
_UniffiConverterOptionalTypeExperimentationArgs.check_lower(experimentation)

return _UniffiConverterMapStringString.lift(_uniffi_rust_call_with_error(_UniffiConverterTypeOperationError,_UniffiLib.uniffi_superposition_core_fn_func_ffi_eval_config,
_UniffiConverterMapStringString.lower(default_config),
_UniffiConverterTypeExtendedMap.lower(default_config),
_UniffiConverterSequenceTypeContext.lower(contexts),
_UniffiConverterMapStringTypeOverrides.lower(overrides),
_UniffiConverterMapStringTypeDimensionInfo.lower(dimensions),
Expand All @@ -1586,8 +1591,8 @@ def ffi_eval_config(default_config: "dict[str, str]",contexts: "typing.List[Cont
_UniffiConverterOptionalTypeExperimentationArgs.lower(experimentation)))


def ffi_eval_config_with_reasoning(default_config: "dict[str, str]",contexts: "typing.List[Context]",overrides: "dict[str, Overrides]",dimensions: "dict[str, DimensionInfo]",query_data: "dict[str, str]",merge_strategy: "MergeStrategy",filter_prefixes: "typing.Optional[typing.List[str]]",experimentation: "typing.Optional[ExperimentationArgs]") -> "dict[str, str]":
_UniffiConverterMapStringString.check_lower(default_config)
def ffi_eval_config_with_reasoning(default_config: "ExtendedMap",contexts: "typing.List[Context]",overrides: "dict[str, Overrides]",dimensions: "dict[str, DimensionInfo]",query_data: "dict[str, str]",merge_strategy: "MergeStrategy",filter_prefixes: "typing.Optional[typing.List[str]]",experimentation: "typing.Optional[ExperimentationArgs]") -> "dict[str, str]":
_UniffiConverterTypeExtendedMap.check_lower(default_config)

_UniffiConverterSequenceTypeContext.check_lower(contexts)

Expand All @@ -1604,7 +1609,7 @@ def ffi_eval_config_with_reasoning(default_config: "dict[str, str]",contexts: "t
_UniffiConverterOptionalTypeExperimentationArgs.check_lower(experimentation)

return _UniffiConverterMapStringString.lift(_uniffi_rust_call_with_error(_UniffiConverterTypeOperationError,_UniffiLib.uniffi_superposition_core_fn_func_ffi_eval_config_with_reasoning,
_UniffiConverterMapStringString.lower(default_config),
_UniffiConverterTypeExtendedMap.lower(default_config),
_UniffiConverterSequenceTypeContext.lower(contexts),
_UniffiConverterMapStringTypeOverrides.lower(overrides),
_UniffiConverterMapStringTypeDimensionInfo.lower(dimensions),
Expand Down
Loading
Loading