Skip to content

Add zizmor (github actions static analysis)#7880

Merged
jtpio merged 1 commit intojupyter:mainfrom
Yann-P:add-zizmor
Apr 21, 2026
Merged

Add zizmor (github actions static analysis)#7880
jtpio merged 1 commit intojupyter:mainfrom
Yann-P:add-zizmor

Conversation

@Yann-P
Copy link
Copy Markdown
Member

@Yann-P Yann-P commented Mar 30, 2026

References

#7879

Code changes

Add one github action triggered when a PR is open

This action is taken from this other jupyter project https://github.com/pydata/pydata-sphinx-theme/blob/main/.github/workflows/zizmor.yml.

User-facing changes

None

Backwards-incompatible changes

None.

@github-actions
Copy link
Copy Markdown
Contributor

Binder 👈 Launch a Binder on branch Yann-P/notebook/add-zizmor

@github-advanced-security
Copy link
Copy Markdown

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

  • The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
  • Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
  • You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

@jtpio
Copy link
Copy Markdown
Member

jtpio commented Apr 8, 2026

Thanks @Yann-P for working on this!

Should we expect CI to fail when the next PR will be opened, since we have not pinned GitHub Actions with hashes on this repo yet?

Curious in which order things should be done, and also whether pinned GitHub Actions can easily be updated later.

@Yann-P
Copy link
Copy Markdown
Member Author

Yann-P commented Apr 8, 2026

Hello @jtpio, it will not block anything because zizmor is only set to trigger when you open a new merge request.

It only alerts about changes that are introduced in the merge request (see screenshot in linked issue)

This means this PR does not address the current security concerns that zizmor found in this repository (I had a quick look and there is nothing too bad).

Copy link
Copy Markdown
Member

@krassowski krassowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from me

Copy link
Copy Markdown
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jtpio jtpio merged commit 60fdfb6 into jupyter:main Apr 21, 2026
37 of 40 checks passed
@Carreau
Copy link
Copy Markdown
Member

Carreau commented Apr 22, 2026

thanks @Yann-P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants