3.6 fix cloud ref accuracy#22764
Open
tmihoc wants to merge 2 commits into
Open
Conversation
Audit of internal/provider/* against the cloud reference docs revealed the following discrepancies, now corrected: amazon-ec2: - Remove allocate-public-ip from constraints (unsupported) - Remove virt-type from constraints (unsupported) - Add arch to instance-type conflict note; add resolver caveat (arch + instance-type allowed when architectures match) google-gce: - Remove arch from instance-type conflict list (arch is not in RegisterConflicts for GCE; container/cores/cpu-power/mem are) microsoft-azure: - Add arm64 to arch constraint valid values (RegisterVocabulary includes both amd64 and arm64) - Add StandardSSD_LRS as the actual default account-type for the azure storage provider (previously only Standard_LRS and Premium_LRS were listed) openstack: - Add access-key authentication type (ec2-compatible endpoints) oracle-oci: - Mark region credential attribute as optional, not required (deprecated field, kept for backward compatibility only) vmware-vsphere: - Correct disk-provisioning-type valid values: thin, thick (default), thick-lazy-zero. The value thickEagerZero does not exist in the vsphereclient code; thick-lazy-zero was undocumented
Add a 'Verifying constraint accuracy against code' sub-section to the 'Adding a new cloud' workflow. Describes the 5-step check against unsupportedConstraints, RegisterConflicts, RegisterVocabulary, RegisterConflictResolver, and silent-ignore detection. Also add a changelog entry recording the corrections made in the 2026-06-30 code accuracy audit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#22577 made significant improvements to the structure and content of our cloud reference docs in
3.6, but while porting the changes to4.0(#22765) I discovered technical correctness issues -- this PR ports them back into3.6.