Add the jsx-a11y/lang rule to the recommended and strict presets#671
Open
astorije wants to merge 1 commit intojsx-eslint:mainfrom
Open
Add the jsx-a11y/lang rule to the recommended and strict presets#671astorije wants to merge 1 commit intojsx-eslint:mainfrom
astorije wants to merge 1 commit intojsx-eslint:mainfrom
Conversation
ljharb
requested changes
Mar 13, 2020
Member
ljharb
left a comment
ljharb
left a comment
There was a problem hiding this comment.
Adding a rule to a preset is a breaking change, so I suspect it was intentional. We can land this whenever something forces a major release.
Contributor
Author
|
Absolutely agree with that, feel free to keep this PR open until the next major version, I'm in no rush :) |
1 similar comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It turns out that
jsx-a11y/langis the only rule not enabled in either recommended or strict presets.I wasn't sure if it was intentional or accidental but I figured it would take me as much time to open an issue asking about it than opening a PR to suggest it. Do what you please with it :)