[Fix] no-static-element-interactions, no-noninteractive-tabindex: add allowExpressionValues to schema#1086
Open
vmvenkatesh78 wants to merge 1 commit intojsx-eslint:mainfrom
Conversation
… add `allowExpressionValues` to schema
vmvenkatesh78
force-pushed
the
fix/allow-expression-values-schema
branch
from
62728d2 to
abfe955
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1073.
Both no-static-element-interactions and no-noninteractive-tabindex destructure allowExpressionValues from options[0] and use it to determine whether non-literal role expressions should be allowed. The option is documented in both rules' docs, tested in both rules' test suites, and included in the recommended configuration examples.
However, neither rule declares allowExpressionValues in its JSON schema. This means ESLint rejects the option during config validation when additionalProperties checking is applied, even though the rule code handles it correctly.
Changes:
Add allowExpressionValues: { type: 'boolean' } to the schema for no-static-element-interactions
Add allowExpressionValues: { type: 'boolean' } to the schema for no-noninteractive-tabindex
No behavioral change. Existing tests pass unmodified