[New] Add ESLint 10 support#1081
Conversation
…on to include support for version 10
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
6b2bccf to
5fba187
Compare
|
I hadd left Node 25 out because tests were crashing... it looked like a Node 25 + ESLint 10 issue at first. Turns out a wrapper was overriding RuleTester.prototype.run and breaking ESLint. I switched it to only hook describe and reran the tests on ESLint 10 from Node 20 to 25, and everything passed locally. I removed the Node 25 exclusion in a seperate commit, and I think now workflow tests will pass. |
|
Great job. |
|
I do hope this lands soon 🙏 |
|
@ljharb, would you be open to reviewing this PR when you get a chance? ESLint 10 has been out for a while now, and this plugin is one of the last major pieces of the ecosystem that doesn't officially support it yet. I've been seeing it referenced in tracking issues across several repos; teams are actively blocked or holding back upgrades waiting on this. The changes are minimal with no new logic, just:
All 132 CI checks pass. Happy to address any feedback! |
|
Hi all, Is there a plan to release this? Any possible ETA? |
Unfortunately, the moderators are not replying. |
Small PR to support ESLint 10, as I need it in one of my side projects.
Hopefully Closes #1075
Made minimal changes to what is needed for compatibility:
typeproperty from invalid test case error objects (ESLint 10 RuleTester breaking change)This is my first time contibuting for this repo.
I'm not experienced in this codebase, but I hope this is sufficient to be compatible with ESLint 10.