Skip to content

[New] Add ESLint 10 support#1081

Open
MohamedAAbdallah wants to merge 4 commits intojsx-eslint:mainfrom
MohamedAAbdallah:eslint-10-support
Open

[New] Add ESLint 10 support#1081
MohamedAAbdallah wants to merge 4 commits intojsx-eslint:mainfrom
MohamedAAbdallah:eslint-10-support

Conversation

@MohamedAAbdallah
Copy link
Copy Markdown

Small PR to support ESLint 10, as I need it in one of my side projects.

Hopefully Closes #1075

Made minimal changes to what is needed for compatibility:

  • Add ESLint ^10 to devDependencies and peerDependencies
  • Add ESLint 10 to CI matrix (Node 20, 21, 22, 24 only; Node 25 excluded due to RuleTester callSite bug)
  • Remove deprecated type property from invalid test case error objects (ESLint 10 RuleTester breaking change)

This is my first time contibuting for this repo.
I'm not experienced in this codebase, but I hope this is sufficient to be compatible with ESLint 10.

@socket-security
Copy link
Copy Markdown

socket-security bot commented Feb 25, 2026

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addednpm/​eslint@​10.0.28910010097100

View full report

@MohamedAAbdallah
Copy link
Copy Markdown
Author

I hadd left Node 25 out because tests were crashing... it looked like a Node 25 + ESLint 10 issue at first.

Turns out a wrapper was overriding RuleTester.prototype.run and breaking ESLint. I switched it to only hook describe and reran the tests on ESLint 10 from Node 20 to 25, and everything passed locally.

I removed the Node 25 exclusion in a seperate commit, and I think now workflow tests will pass.

@luas10c
Copy link
Copy Markdown

luas10c commented Mar 5, 2026

Great job.

@codenomnom
Copy link
Copy Markdown

I do hope this lands soon 🙏

@MohamedAAbdallah
Copy link
Copy Markdown
Author

@ljharb, would you be open to reviewing this PR when you get a chance?

ESLint 10 has been out for a while now, and this plugin is one of the last major pieces of the ecosystem that doesn't officially support it yet. I've been seeing it referenced in tracking issues across several repos; teams are actively blocked or holding back upgrades waiting on this.

The changes are minimal with no new logic, just:

  • ESLint 10 added to peer/devDependencies
  • CI matrix expanded for Node 20+
  • type property removed from RuleTester error objects (ESLint 10 breaking change)
  • A small fix to the RuleTester wrapper that was incompatible with ESLint 10 internals

All 132 CI checks pass. Happy to address any feedback!

@nandeshwarshubh
Copy link
Copy Markdown

Hi all, Is there a plan to release this? Any possible ETA?

@MohamedAAbdallah
Copy link
Copy Markdown
Author

Hi all, Is there a plan to release this? Any possible ETA?

Unfortunately, the moderators are not replying.
Hope this one gets reviewed soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade to ESLint v10 [Feature] Support for ESLint v10

4 participants