【Fix】: alt-text string null determination#1013
Draft
taku10101 wants to merge 1 commit intojsx-eslint:mainfrom
Draft
【Fix】: alt-text string null determination#1013taku10101 wants to merge 1 commit intojsx-eslint:mainfrom
taku10101 wants to merge 1 commit intojsx-eslint:mainfrom
Conversation
taku10101
changed the title
ljharb
requested changes
Oct 7, 2024
Member
ljharb
left a comment
ljharb
left a comment
There was a problem hiding this comment.
This would need some tests to show what bug is being fixed.
| return false; | ||
| } | ||
| if (typeof value === 'string' && value.length === 0) { | ||
| if (typeof value === 'string' && value.length === 0 && value === '') { |
Member
There was a problem hiding this comment.
value === '' and value.length === 0, when it's already a string, are the same condition.
Suggested change
| if (typeof value === 'string' && value.length === 0 && value === '') { | |
| if (typeof value === 'string' && value.length === 0) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closed #971