Skip to content

fix: treat HTAB as optional whitespace in If-None-Match / If-Match lists #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blakeembrey merged 1 commit into from
Jun 23, 2026
Merged

fix: treat HTAB as optional whitespace in If-None-Match / If-Match lists #77

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,7 @@ function parseTokenList (str) {
// gather tokens
for (var i = 0, len = str.length; i < len; i++) {
switch (str.charCodeAt(i)) {
case 0x09: /* HTAB */
case 0x20: /* */
if (start === end) {
start = end = i + 1
Expand Down
6 changes: 6 additions & 0 deletions test/fresh.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,12 @@ describe('fresh(reqHeaders, resHeaders)', function () {
var resHeaders = { etag: '"foo"' }
assert.ok(fresh(reqHeaders, resHeaders))
})

it('should be fresh when the list is separated with tabs', function () {
var reqHeaders = { 'if-none-match': '"bar",\t"foo"' }
var resHeaders = { etag: '"foo"' }
assert.ok(fresh(reqHeaders, resHeaders))
})
})

describe('when etag is missing', function () {
Expand Down
Loading