Skip to content

Mention "Bytes" on README.md and lib.rs#536

Merged
bors[bot] merged 3 commits into
jonasbb:masterfrom
ryoqun:improved-bytes-doc-coverage
Dec 24, 2022
Merged

Mention "Bytes" on README.md and lib.rs#536
bors[bot] merged 3 commits into
jonasbb:masterfrom
ryoqun:improved-bytes-doc-coverage

Conversation

@ryoqun
Copy link
Copy Markdown
Contributor

@ryoqun ryoqun commented Dec 23, 2022

I think #277 can be more promoted. :)

As I wrote the current status of serialization of const generics like bytes (solana-labs/solana#29196 (comment)), i think "Bytes" is best solution so far.

@jonasbb hey, this functionary saved us. however it took a while to spot this. I think Bytes can be promoted. :)

@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 23, 2022

Codecov Report

Merging #536 (bb695a4) into master (d06b021) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #536   +/-   ##
=======================================
  Coverage   50.79%   50.79%           
=======================================
  Files          36       36           
  Lines        2262     2262           
=======================================
  Hits         1149     1149           
  Misses       1113     1113           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jonasbb
Copy link
Copy Markdown
Owner

jonasbb commented Dec 24, 2022

Hi, I'm glad you found this crate useful :). The lack of const-generic support in serde_bytes seems to come up from time to time, so calling out support for it in the README could be useful. Thanks for the PR.

bors r+

@bors
Copy link
Copy Markdown
Contributor

bors Bot commented Dec 24, 2022

Build succeeded:

@bors bors Bot merged commit d76f283 into jonasbb:master Dec 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants