Skip to content

feature: Signer.create taking a JOSE.JWK #448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bobergj wants to merge 1 commit into
base: main
Choose a base branch
from
+22 −0
Open

feature: Signer.create taking a JOSE.JWK #448

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions lib/joken/signer.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,14 @@ defmodule Joken.Signer do
)
end

def create(alg, %JWK{} = key, headers) when alg in @map_key_algorithms do
raw_create(
alg,
headers |> transform_headers(alg) |> JWS.from_map(),
key
)
end

def create(alg, key, headers) when is_map(key) and alg in @map_key_algorithms do
raw_create(
alg,
Expand Down
14 changes: 14 additions & 0 deletions test/joken_signer_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,20 @@ defmodule Joken.Signer.Test do
} = signer
end

test "can create a signer from a JOSE JWK" do
map = Application.get_env(:joken, :rs256)[:key_map]
jwk = JOSE.JWK.from_map(map)
signer = Signer.create("RS256", jwk)

assert %Signer{
alg: "RS256",
jws: %JOSE.JWS{
alg: {:jose_jws_alg_rsa_pkcs1_v1_5, :RS256}
},
jwk: ^jwk
} = signer
end

test "raise with invalid parameter" do
assert_raise Error, Error.message(%Error{reason: :algorithm_needs_key}), fn ->
Signer.create("RS256", "Not a map")
Expand Down
Loading