Skip to content

Add function to create VaultClient with reqwest Client#190

Open
collinoc wants to merge 1 commit into
jmgilman:masterfrom
collinoc:user-given-http-client
Open

Add function to create VaultClient with reqwest Client#190
collinoc wants to merge 1 commit into
jmgilman:masterfrom
collinoc:user-given-http-client

Conversation

@collinoc
Copy link
Copy Markdown

Recently ran into a scenario where I wanted to set the pool idle timeout on the inner client. I figure letting users supply their own reqwest client is easier than adding another field to VaultClientSettings anytime another nice-to-have comes up.

@stormshield-gt
Copy link
Copy Markdown
Collaborator

I think the direction we want to go now is to remove the public dependency on reqwest. The idea will be to provide better stability, i.e., avoid breaking when reqwest breaks. I will be open to a PR that adds the config options.

We can further discuss the reqwest situation here #152 if you want

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants