Allow using strict HTTP verbs instead of LIST#130
Open
toomai wants to merge 1 commit into
Open
Conversation
Collaborator
|
Thanks for opening a PR ! I like the idea of handling this with middleware rather than having to distinct requests for LIST and GET with I want to explore a little bit with #105 and see I can directly generate
Any contributions are welcomed! If you do so, please add some tests to the PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vault default to LIST HTTP verbs which is not (yet ?) RFC compliant and can cause problems in some setups. I propose a new settings, defaulting to false. This will trigger request transformation and switch to GET request with the
list=truequery parameter.Saw one referenced issue #109. I saw the decision was taken to use GET request all the time but this has been ready for a long time on my side. I just forgot to PR it, let me know if you still plan on using GET.
I also have another feature on a different branch to add the ListIssuer and ListIssuerCrl calls, let me know if you'd be interested to merge these too.