Skip to content

chore: move clip models#945

Open
zihao-jing wants to merge 16 commits intomainfrom
mv-clip-models
Open

chore: move clip models#945
zihao-jing wants to merge 16 commits intomainfrom
mv-clip-models

Conversation

@zihao-jing
Copy link
Copy Markdown
Contributor

No description provided.

@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 29, 2023

Codecov Report

❌ Patch coverage is 83.33333% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.71%. Comparing base (ca2b25b) to head (3ac7d2b).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
server/clip_server/model/clip_onnx.py 81.81% 2 Missing ⚠️
server/clip_server/model/pretrained_models.py 84.61% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #945      +/-   ##
==========================================
+ Coverage   70.73%   71.71%   +0.98%     
==========================================
  Files          23       23              
  Lines        1565     1584      +19     
==========================================
+ Hits         1107     1136      +29     
+ Misses        458      448      -10     
Flag Coverage Δ
cas 71.71% <83.33%> (+0.98%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@zihao-jing zihao-jing marked this pull request as draft January 5, 2024 11:54
@zihao-jing
Copy link
Copy Markdown
Contributor Author

All the torch models have been migrated and tested. The onnx models will be migrated later due to my network.

@zihao-jing zihao-jing marked this pull request as ready for review January 15, 2024 05:22
@zihao-jing zihao-jing requested a review from numb3r3 January 15, 2024 05:22
Comment thread server/clip_server/model/pretrained_models.py Outdated
@zihao-jing zihao-jing requested review from ZiniuYu and removed request for numb3r3 January 15, 2024 17:00
@zihao-jing
Copy link
Copy Markdown
Contributor Author

What's the 'codecov' problem? Do you think that needs a unit test to cover?

@zihao-jing
Copy link
Copy Markdown
Contributor Author

All the onnx and torch models have been transferred to huggingface successfully by now.

@zihao-jing zihao-jing requested a review from numb3r3 January 19, 2024 10:35
Comment thread server/clip_server/model/clip_onnx.py Outdated
Comment thread server/clip_server/model/pretrained_models.py Outdated
Comment thread server/clip_server/model/clip_onnx.py Outdated
@zihao-jing zihao-jing requested a review from ZiniuYu January 22, 2024 08:40
Copy link
Copy Markdown
Contributor Author

@zihao-jing zihao-jing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finished remove s3 download address

Comment thread server/clip_server/torch-flow.yml Outdated
@zihao-jing zihao-jing requested a review from ZiniuYu January 23, 2024 10:51
Comment thread client/setup.py
install_requires=[
'jina>=3.12.0',
'docarray[common]>=0.19.0,<0.30.0',
'docarray[common]==0.21.0',
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This requirement is too strong. Could we have some flexible version bump here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants