CSS cleanup for syntax.html - #409
Open
clarfonthey wants to merge 3 commits into
Open
Conversation
clarfonthey
force-pushed
the
syntax-css
branch
from
August 25, 2026 03:30
b6a5332 to
ece3bef
Compare
clarfonthey
commented
Aug 25, 2026
| color: light-dark(#1a1a1a, #fdfdfd); | ||
| background-color: #fdfdfd; | ||
| background-color: light-dark(#fdfdfd, #1a1a1a); | ||
| color-scheme: light dark; |
Author
There was a problem hiding this comment.
This is required to tell the browser the website actually supports dark mode. It's still only used if the browser requests it.
Owner
|
syntax.html is actually a generated file (see the Makefile rule for it). The CSS is produced by pandoc (it's part of the default pandoc HTML template). (You could consider making a PR there...data/templates/styles.html) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split into three commits:
currentColor(supported since 2010, 98% browser usage)light-darksyntax to add dark mode styles (uses fallback since this standard is from 2024-ish, 88% usage)Not actually sure you care that much about browser support for these features, but figured I'd be conservative anyway while making it so that the CSS is easy to modify if needed.