Skip to content

Make the signing key optinal jf release-bundle-create#2762

Merged
eyalbe4 merged 5 commits into
jfrog:devfrom
oshratZairi:optinalSigningKey
Nov 21, 2024
Merged

Make the signing key optinal jf release-bundle-create#2762
eyalbe4 merged 5 commits into
jfrog:devfrom
oshratZairi:optinalSigningKey

Conversation

@oshratZairi

@oshratZairi oshratZairi commented Nov 17, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....

Turn the signing key flag to optional for RBC and in RBP command.
Documentation PR jfrog/documentation#172

@lesnerd lesnerd added the improvement Automatically generated release notes label Nov 17, 2024
@lesnerd
lesnerd requested review from RobiNino, eyalbe4 and lesnerd and removed request for lesnerd November 17, 2024 14:52
@lesnerd lesnerd added the safe to test Approve running integration tests on a pull request label Nov 17, 2024
@github-actions github-actions Bot removed the safe to test Approve running integration tests on a pull request label Nov 17, 2024
@lesnerd lesnerd added the safe to test Approve running integration tests on a pull request label Nov 17, 2024
@github-actions github-actions Bot removed the safe to test Approve running integration tests on a pull request label Nov 17, 2024
@lesnerd lesnerd added the safe to test Approve running integration tests on a pull request label Nov 18, 2024
@github-actions github-actions Bot removed the safe to test Approve running integration tests on a pull request label Nov 18, 2024
@eyalbe4 eyalbe4 added the safe to test Approve running integration tests on a pull request label Nov 20, 2024
@github-actions github-actions Bot removed the safe to test Approve running integration tests on a pull request label Nov 20, 2024
eyalbe4
eyalbe4 suggested changes Nov 20, 2024
View reviewed changes
Comment thread lifecycle_test.go
Comment thread lifecycle_test.go Outdated
Comment thread utils/cliutils/commandsflags.go Outdated
@eyalbe4 eyalbe4 changed the title Optinal signing key for RBC Make the signing key optinal jf release-bundle-create Nov 20, 2024
@eyalbe4 eyalbe4 added the safe to test Approve running integration tests on a pull request label Nov 20, 2024
@github-actions github-actions Bot removed the safe to test Approve running integration tests on a pull request label Nov 20, 2024
@lesnerd lesnerd added the safe to test Approve running integration tests on a pull request label Nov 20, 2024
@github-actions github-actions Bot removed the safe to test Approve running integration tests on a pull request label Nov 20, 2024
@eyalbe4
eyalbe4 merged commit 6fa5830 into jfrog:dev Nov 21, 2024
oshratZairi added a commit to oshratZairi/jfrog-cli that referenced this pull request Nov 27, 2024
@oshratZairi
Make the signing key optinal jf release-bundle-create (jfrog#2762)
bb3329f
@BrewTestBot BrewTestBot mentioned this pull request Nov 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RobiNino RobiNino Awaiting requested review from RobiNino
1 more reviewer
@eyalbe4 eyalbe4 eyalbe4 requested changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

improvement Automatically generated release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@oshratZairi @eyalbe4 @lesnerd