Allow parsing cast expressions.#33
Conversation
reitermarkus
force-pushed
the
cast-expr
branch
3 times, most recently
from
458ae2e to
5354667
Compare
reitermarkus
force-pushed
the
cast-expr
branch
from
f7986ce to
9e59566
Compare
emilio
left a comment
emilio
left a comment
There was a problem hiding this comment.
At a glance it looks reasonable, but I'm confused about the patch section, can you clarify whether you intend that to be merged?
| clang = { version = "2", features = ["runtime"] } | ||
|
|
||
| [patch.crates-io] | ||
| clang-sys = { git = "https://github.com/reitermarkus/clang-sys", branch = "load-api" } |
There was a problem hiding this comment.
Can you upstream or remove this? It seems unfortunate not depending on the crates.io version.
There was a problem hiding this comment.
An upstream PR is already opened. This is only needed for the last commit in this PR, cleaning up the test setup.
There was a problem hiding this comment.
Would it be possible to split the test setup cleanup into its own PR? Seems like there's some push back against making the change to clang-sys since it's a breaking change...
|
@emilio @reitermarkus Would either of you be opposed to creating a fork of this PR minus the dependency on the new |
|
@dpaoliello, I have given up on Sadly no one has reviewed my PR at rust-lang/rust-bindgen#2369 replacing |
3 participants
Revival of #15.