fix: visual mode highlight lingers after put#341
Open
hernancerm wants to merge 1 commit intojeffreytse:masterfrom
Open
fix: visual mode highlight lingers after put#341hernancerm wants to merge 1 commit intojeffreytse:masterfrom
hernancerm wants to merge 1 commit intojeffreytse:masterfrom
Conversation
b5c5c9b to
be23742
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The highlight set after a normal mode
porPlingers. Currentmasterbehavior:hl-lingers-after-put.mp4
Solution
Do not highlight text put with
porP(changes inzvm_vi_put_afterandzvm_vi_put_before).Personally, I don't use highlights for yank/put, so I'm happy with this solution. Nonetheless, I understand if this removal is not desired, I listed alternative solutions below. Let me know if you want me to rework the solution. Behavior from this branch:
hl-lingers-after-put-fixed.mp4
Alternative solutions
bindkey -e(emacs) or p/P onbindkey -v(vi).The alternative solution 1 seems more correct than the solution of this branch, as it would make ZVM match the behavior of
bindkey -vinsofar highlights, but the cost would be (likely) scatteringzvm_highlight clearon every place where the cursor can be moved.Notes
Related: #329
The videos were recorded using vhs with this tape file so the inputs are exactly the same on both tests:
hl-lingers-after-put.tapeThanks for the plugin!