Make implicitly global parameter declarations local#173
Open
Saklad5 wants to merge 1 commit intojeffreytse:masterfrom
Open
Make implicitly global parameter declarations local#173Saklad5 wants to merge 1 commit intojeffreytse:masterfrom
Saklad5 wants to merge 1 commit intojeffreytse:masterfrom
Conversation
a30c677 to
188edef
Compare
Author
|
I'm working on the assumption that all implicit global variables are unintentional, such that simply making them local fixes the issue. If any of them are meant to be global, they should be explicitly global: while I very much doubt any of these fall into that category, I recommend briefly skimming the changes before merging. I will continue to force-push additional fixes along the same lines if I encounter any until it is merged. |
These parameters were not explictly marked as local, which causes zsh to make them global by default. This is presumably unintended, and pollutes the environment, so they have been explicitly made local in the manner already present in the file. These parameters were found using the zsh option WARN_CREATE_GLOBAL. There may be other implicit global parameters present, as it only displays a warning when the relevant code is evaluated.
188edef to
d2f992f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These parameters were not explictly marked as local, which causes zsh to
make them global by default. This is presumably unintended, and pollutes
the environment, so they have been explicitly made local in the manner
already present in the file.
These parameters were found using the zsh option WARN_CREATE_GLOBAL.
There may be other implicit global parameters present, as it only
displays a warning when the relevant code is evaluated.