Document the performance-toolkit fixture generator conflict - #42
Merged
Merged
Conversation
…e generator conflict
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documents a conflict between this module and the performance toolkit, found while running the
stress suite against a 2.4.9 install.
setup:performance:generate-fixturesaborts withThe entity ID field for the "queue_message" table wasn't foundwheneverMagento_InventoryStockVisualizeris enabled.The chain:
SqlCollectorto capture, throughthe DB profiler, every
INSERT INTOthat save emits — it assumes each captured table belongsto the product entity.
(
PurgeOnSourceItemsSave) and publishes a purge message onto the database-backed queue, soINSERT INTO queue_messagelands in that set.EntityGenerator::getEntityIdField()then looks for a foreign key fromqueue_messagetocatalog_product_entity, finds none, and throws.Confirmed by disabling the module: the same profile that aborted then generated 1600
product_dynamic_*products in 22s. Re-enabling it and recompiling DI leaves the catalog intact,so the workaround is limited to the generation window.
This is not a regression from the upstream sync. The failure was initially suspected to come from
ACP2E-4349(which dropped the pinnedqueue="…"publisher attribute), so that was testeddirectly: restoring the attribute on the three
queue_publisher.xmlfiles reproduced the abortidentically. The trigger is the purge publish itself, not which queue name it targets.
Fixture generation is the only thing affected — storefront and admin behaviour are untouched. Any
module publishing to the database-backed queue during a product save hits the same generator
limitation, so the note is worded accordingly.
Documentation only; no code changes. The QA gate reports no PHP files to check.