4916 refactor chips element#5111
Open
NewerNaigil wants to merge 13 commits intoangular_rework_developmentfrom
Open
4916 refactor chips element#5111NewerNaigil wants to merge 13 commits intoangular_rework_developmentfrom
NewerNaigil wants to merge 13 commits intoangular_rework_developmentfrom
Conversation
pnatashap
requested changes
Nov 2, 2023
MayaElf
requested changes
Nov 3, 2023
NewerNaigil
force-pushed
the
4916_refactor_Chips_element
branch
from
5daa422 to
aad3991
Compare
This was
linked to
issues
Nov 22, 2023
pnatashap
requested changes
Nov 22, 2023
|
|
||
| import java.util.List; | ||
|
|
||
| public interface IsGroupElement<A extends UIBaseElement<?>> extends ICoreElement { |
Contributor
There was a problem hiding this comment.
Есть интерфейс IList, вроде в нем есть все это
Contributor
There was a problem hiding this comment.
@NewerNaigil никаких комментариев почему-то не вижу
pnatashap
requested changes
Nov 24, 2023
added 6 commits
February 1, 2024 15:33
…ement # Conflicts: # jdi-light-angular-tests/src/main/java/io/github/com/StaticSite.java # jdi-light-angular-tests/src/main/java/io/github/com/pages/AngularPage.java # jdi-light-angular/src/main/java/com/epam/jdi/light/angular/asserts/ChipsAssert.java # jdi-light-angular/src/main/java/com/epam/jdi/light/angular/elements/complex/AutoComplete.java # jdi-light-angular/src/main/java/com/epam/jdi/light/angular/elements/complex/Chips.java
pnatashap
requested changes
Feb 11, 2024
| /** | ||
| * Represents an element that has an {@link Image}. | ||
| */ | ||
| public interface HasImage extends ICoreElement { |
Contributor
There was a problem hiding this comment.
HasImage interface and HasImageAssert are in html project, we should use it
Contributor
There was a problem hiding this comment.
Есть интерфейс HasImage в jdi-light-html пакете, надо использовать его, этот удалить
|
|
||
| import java.util.List; | ||
|
|
||
| public interface IsGroupElement<A extends UIBaseElement<?>> extends ICoreElement { |
Contributor
There was a problem hiding this comment.
@NewerNaigil никаких комментариев почему-то не вижу
| */ | ||
| @JDIAction("Get if '{name}' is vertical") | ||
| default boolean isVertical() { | ||
| return core().attr("class").contains("-vertical"); |
Contributor
There was a problem hiding this comment.
это очень плохая реализация: например у нас есть класс line-vertical-divider может вообще не иметь ничего общего с ориентацией, потому что текст после мы проигнорировали.
сколько элементов еще имеет такую характеристику?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.