4952 + 4964: Angular grid list class implementation and refactoring tests#5085
Open
b14ckster wants to merge 37 commits intoangular_rework_developmentfrom
Open
4952 + 4964: Angular grid list class implementation and refactoring tests#5085b14ckster wants to merge 37 commits intoangular_rework_developmentfrom
b14ckster wants to merge 37 commits intoangular_rework_developmentfrom
Conversation
This was
linked to
issues
Sep 27, 2023
pnatashap
requested changes
Oct 12, 2023
b14ckster
force-pushed
the
angular_grid_list_class_implementation
branch
from
520353e to
f2f26c5
Compare
pnatashap
requested changes
Oct 13, 2023
MayaElf
changed the title
…s_implementation # Conflicts: # jdi-light-angular-tests/src/main/java/io/github/com/StaticSite.java
and moved to common folder with gridList Tests updated basic grid list removed from tests
pnatashap
requested changes
Jan 5, 2024
spbqaru
approved these changes
Jan 16, 2024
vklonin
reviewed
Feb 2, 2024
pnatashap
requested changes
Feb 2, 2024
vklonin
approved these changes
Feb 8, 2024
pnatashap
requested changes
Feb 8, 2024
| @JDIAction("Assert that '{name}' has number of columns '{0}'") | ||
| public GridListAssert cols(int expectedCols) { | ||
| jdiAssert(element().cols(), Matchers.is(expectedCols), | ||
| String.format("\nActual number of columns in Grid List: '%s'\n" + |
Contributor
There was a problem hiding this comment.
стандартное сообщение матчера нормальное, к нему все привыкли
| */ | ||
| @JDIAction(value = "Assert that '{name}' is empty", isAssert = true) | ||
| public GridListAssert empty() { | ||
| jdiAssert(element().tiles().isEmpty(), Matchers.is(true), "List is not empty"); |
Contributor
There was a problem hiding this comment.
- есть матчер для пустой коллекции
- сообщение List is not empty не понятно, какой такой лист? мы tile проверяем, вот и написать, что tile есть или нет
| */ | ||
| @JDIAction("Assert that each of '{name}' elements meet condition") | ||
| public GridListAssert each(JFunc1<GridTile, Boolean> condition) { | ||
| jdiAssert(LinqUtils.all(element().tiles(), condition::execute), Matchers.is(true), "Not all elements meet condition"); |
Contributor
There was a problem hiding this comment.
я может что-то не поняла, а почему мы не используем Matcher.allOf и с матчером внутри?
сообщение, что не все элементы невозможно потом понять, потому что инфа, что собственно не прошло, теряется, зачем перебивать сообщение об ошибке родное? и делать его нечитаемым?
| .and().gutterSize("10px") | ||
| .and().notEmpty() | ||
| .and().size(4) | ||
| .each(ICoreElement::isVisible) |
Contributor
There was a problem hiding this comment.
стиль кода поехал, давайте единообразно писать
| .and().colspan(1) | ||
| .and().rowspan(2); | ||
|
|
||
| dynamicGridList.tileByIndex(2).find(".avatar-img").is() |
Contributor
There was a problem hiding this comment.
не надо вот такое писать, кастомный локатор в тесте - плохая практика, мы тут пытаемся показать, как это используется правильно.
правильный метод - сделать кастомный tile с валидатором
…erts/gridlist/GridListAssert.java Co-authored-by: Natalia Pozhidaeva <Natalia_Pozhidaeva@epam.com>
…ests/elements/complex/GridListTests.java Co-authored-by: Natalia Pozhidaeva <Natalia_Pozhidaeva@epam.com>
…tation' into angular_grid_list_class_implementation
pnatashap
requested changes
Feb 13, 2024
| public class CustomGridTileWithImage extends GridTile { | ||
|
|
||
| @UI("#dynamic-grid-item-avatar") | ||
| public UIElement image; |
Contributor
There was a problem hiding this comment.
я скоро добавлю в checkstyle условие, чтобы никто не писал, что image имеет тип UIElement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"У нас есть enum для цветов, надо для него тоже assert сделать" - добавить использование
jdi-light-angular/src/main/java/com/epam/jdi/light/angular/elements/enums/AngularColors.java