bugfix: fix the accuracy error of NPU xattention.#1303
Merged
LMX-xin merged 1 commit intojd-opensource:mainfrom Apr 20, 2026
Merged
bugfix: fix the accuracy error of NPU xattention.#1303LMX-xin merged 1 commit intojd-opensource:mainfrom
LMX-xin merged 1 commit intojd-opensource:mainfrom
Conversation
LMX-xin
requested review from
DongheJin,
JimHsiung,
RobbieLeung,
XuZhang99,
liutongxuan,
walsonyang and
yq33victor
as code owners
XuZhang99
previously approved these changes
Apr 17, 2026
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the xllm_ops subproject and refactors the NPU beam search implementation in rec_worker_impl.cpp to manually initialize beam tensors during the first round. A logic error was identified where out_token_index and out_beam_count_prefix_sums are incorrectly zeroed, which breaks functionality for batch sizes greater than one. The reviewer provided a code block to correctly calculate base indices for proper KV cache selection and output attribution.
LMX-xin
force-pushed
the
feat/xllm_npu_xattention
branch
from
9e444ef to
4e5a6de
Compare
LMX-xin
force-pushed
the
feat/xllm_npu_xattention
branch
from
4e5a6de to
512ef71
Compare
DragonFive
approved these changes
Apr 20, 2026
walsonyang
approved these changes
Apr 20, 2026
maojunx99
pushed a commit
to maojunx99/xllm
that referenced
this pull request
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.