perf: add llm decode metadata update fast path.#1294
Merged
RobbieLeung merged 1 commit intojd-opensource:mainfrom Apr 28, 2026
Merged
perf: add llm decode metadata update fast path.#1294RobbieLeung merged 1 commit intojd-opensource:mainfrom
RobbieLeung merged 1 commit intojd-opensource:mainfrom
Conversation
Collaborator
RobbieLeung
commented
Apr 16, 2026
RobbieLeung
commented
- add a decode-only fused metadata update kernel for ordinary LLM CUDA graph execution
- reuse persistent kv seq len delta buffers and keep block_tables on the legacy copy path
- add decode fast-path coverage and fallback equivalence tests
RobbieLeung
requested review from
DongheJin,
JimHsiung,
XuZhang99,
liutongxuan,
walsonyang and
yq33victor
as code owners
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This PR implements a CUDA-based fast path for updating LLM decode metadata, replacing standard copy operations to optimize persistent buffer management in the CUDA graph executor. Feedback primarily addresses style guide compliance, including renaming functions to snake_case, replacing magic numbers with named constants, annotating constant arguments, and removing an unused include.
Collaborator
|
加一个启用 |
- add a decode-only fused metadata update kernel for ordinary LLM CUDA graph execution - reuse persistent kv seq len delta buffers and keep block_tables on the legacy copy path - add decode fast-path coverage and fallback equivalence tests
Collaborator
Author
让AI写了个benchmark，加速了2-2.6x左右 |
RobbieLeung
force-pushed
the
feat/fast_graph
branch
from
6e86fe3 to
c0b88d1
Compare
Collaborator
我的意思可以贴上GPU profiling timeline 的图示，展示效果更清晰 |
zhang-minchao
approved these changes
Apr 18, 2026
liutongxuan
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.