feat: support REC extended item info parsing and response output.#1282
feat: support REC extended item info parsing and response output.#1282DragonFive wants to merge 5 commits intojd-opensource:mainfrom
Conversation
DragonFive
requested review from
DongheJin,
JimHsiung,
RobbieLeung,
XuZhang99,
liutongxuan,
walsonyang and
yq33victor
as code owners
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces support for extended item information (DID and type) in recommendation outputs by updating the vocabulary dictionary, tokenizer, and API service logic. Feedback highlights a misalignment between item IDs and extended info tensors in the service implementation, a regression in sequence output generation that fails to handle multiple item matches, and a potential memory exhaustion vulnerability when parsing the vocabulary file. Additionally, the new global flag must be registered in help_formatter.h to comply with the repository's style guide.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces support for extended item information (DID and type) across the recommendation service, including updates to vocabulary parsing, tokenization, and API response handling. The review feedback correctly identifies a protocol buffer field mismatch in the API service and suggests more robust error handling in the vocabulary loader to prevent silent failures when encountering incomplete file records.
3 participants
add extended item info in filter bin for beam search.