bugfix: fix mtp prefix cache prefill starvation.#1264
Merged
phantomlei3 merged 2 commits intojd-opensource:mainfrom Apr 25, 2026
Merged
bugfix: fix mtp prefix cache prefill starvation.#1264phantomlei3 merged 2 commits intojd-opensource:mainfrom
phantomlei3 merged 2 commits intojd-opensource:mainfrom
Conversation
phantomlei3
requested review from
DongheJin,
JimHsiung,
RobbieLeung,
XuZhang99,
liutongxuan,
walsonyang and
yq33victor
as code owners
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces an explicit reference counting mechanism for physical blocks to improve the accuracy of usage tracking, particularly when prefix caching is enabled. It also updates the prefill scheduler to bypass memory threshold checks when using the prefix cache. The review feedback identifies critical thread-safety risks due to non-atomic updates of the new reference counters and notes a style guide violation regarding the use of auto for primitive types.
RobbieLeung
reviewed
Apr 13, 2026
yq33victor
reviewed
Apr 14, 2026
phantomlei3
force-pushed
the
bugfix/mtp-prefix-cache
branch
from
5f34a91 to
83b7791
Compare
phantomlei3
force-pushed
the
bugfix/mtp-prefix-cache
branch
from
83b7791 to
801f372
Compare
yq33victor
reviewed
Apr 22, 2026
phantomlei3
force-pushed
the
bugfix/mtp-prefix-cache
branch
from
d741666 to
27e07e4
Compare
liutongxuan
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.