SSEOxyGent payload exclude callee/callee_category#131
Open
zhouxuezhen wants to merge 1 commit intojd-opensource:mainfrom
Open
SSEOxyGent payload exclude callee/callee_category#131zhouxuezhen wants to merge 1 commit intojd-opensource:mainfrom
zhouxuezhen wants to merge 1 commit intojd-opensource:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
修改
SSEOxyGent请求外部MAS应用的payload,剔除参数callee和callee_category。Why
SSEOxyGent能够做MAS应用之间的集成,在MAS.chat_with_agent方法的实现中(如下),会优先从http请求的payload中获取callee。这也就意味着:如果SSEOxyGent实例在调用外部MAS系统/sse/chat接口时把自身的callee和callee_category传输过去了,将会发生以下情况:这也就意味着,必须要知道外部MAS系统的节点名称,并且保证自己的SSEOxyGent节点名称与之想通,才能够得到正确的结果,这会导致系统之间的耦合!如果默认把
callee和callee_category从payload中排除,在调用外部MAS系统的/sse/chat接口时,会默认从它的master节点开始执行,这应该是一个惯性思维下想要的结果。另外,在调用SSEOxyGent实例之前,在oxy_request.arguments中传输callee参数,依旧能够达到指定调用外部MAS系统某一个节点能力的效果(但个人感觉这不是一个好的用法,外部MAS系统的改造随时会带来可用性上的风险),因为在 SSEOxyGent 中处理payload时优先采用了oxy_request.arguments中的参数(如下):基于以上,提出这个细微的调整
Checklist